>I have read that fall requeening every couple of years makes good sense.
Some people requeen twice a year. Some never. Pretty much I never requeen unless I see the queen failing. The bees should be able to replace a failing queen. This is a genetic trait we will breed out of the bees if we keep interfering.
>I have my one hive that started as a package last year, over came chalk brood and really did well, made lots of honey, and survived a cold winter. I think the genetics of this hive is pretty good.
Then keep her.
>Well this fall will be two years and I am wondering if it would make sense to 'off' the queen in September and let them make a new one, or buy a new one of questionable genetics.
You have one you like. At most, why not pull her with a frame of brood and a frame of honey and adhering bees and let the hive raise a new one.